Discussion:
[Freeipa-devel] [freeipa PR#559][opened] WebUI: Certificate login
pvomacka
2017-03-09 09:01:33 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Author: pvomacka
Title: #559: WebUI: Certificate login
Action: opened

PR body:
"""
https://pagure.io/freeipa/issue/6225
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/559/head:pr559
git checkout pr559
pvomacka
2017-03-09 11:19:51 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Author: pvomacka
Title: #559: WebUI: Certificate login
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/559/head:pr559
git checkout pr559
dkupka
2017-03-09 11:39:47 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Title: #559: WebUI: Certificate login

dkupka commented:
"""
@pvomacka NACK, see lint errors in travis.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/559#issuecomment-285329218
pvomacka
2017-03-09 11:53:05 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Author: pvomacka
Title: #559: WebUI: Certificate login
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/559/head:pr559
git checkout pr559
pvomacka
2017-03-09 12:34:52 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Author: pvomacka
Title: #559: WebUI: Certificate login
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/559/head:pr559
git checkout pr559
pvomacka
2017-03-09 13:12:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Author: pvomacka
Title: #559: WebUI: Certificate login
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/559/head:pr559
git checkout pr559
pvomacka
2017-03-09 13:18:11 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Title: #559: WebUI: Certificate login

pvomacka commented:
"""
@pvoborni thank you for review. Fixed all proposed changes.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/559#issuecomment-285348733
pvomacka
2017-03-12 19:37:11 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Author: pvomacka
Title: #559: WebUI: Certificate login
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/559/head:pr559
git checkout pr559
pvomacka
2017-03-14 08:25:46 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Author: pvomacka
Title: #559: WebUI: Certificate login
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/559/head:pr559
git checkout pr559
pvomacka
2017-03-14 08:38:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Author: pvomacka
Title: #559: WebUI: Certificate login
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/559/head:pr559
git checkout pr559
pvomacka
2017-03-14 09:14:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Author: pvomacka
Title: #559: WebUI: Certificate login
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/559/head:pr559
git checkout pr559
dkupka
2017-03-14 14:12:59 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Title: #559: WebUI: Certificate login

dkupka commented:
"""
LGTM and works.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/559#issuecomment-286433331
dkupka
2017-03-14 14:12:58 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Title: #559: WebUI: Certificate login

Label: +ack
dkupka
2017-03-14 14:14:24 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Author: pvomacka
Title: #559: WebUI: Certificate login
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/559/head:pr559
git checkout pr559
dkupka
2017-03-14 14:14:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Title: #559: WebUI: Certificate login

Label: +pushed
dkupka
2017-03-14 14:14:21 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Title: #559: WebUI: Certificate login

dkupka commented:
"""
master:

* 75c592d3b9081474cae51c929e6af29c7a0eebb6 Support certificate login after installation and upgrade
* 585547ee9478ea0173106d88d40d7807baab8bcf WebUI: add link to login page which for login using certificate
"""

See the full comment at https://github.com/freeipa/freeipa/pull/559#issuecomment-286433787
simo5
2017-03-14 16:30:37 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Title: #559: WebUI: Certificate login

simo5 commented:
"""
NACK NACK NACK
Pleas revert the change to the gssproxy template, it undoes half the work done in privilege separation
"""

See the full comment at https://github.com/freeipa/freeipa/pull/559#issuecomment-286478501
simo5
2017-03-14 16:31:17 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Title: #559: WebUI: Certificate login

simo5 commented:
"""
You need to wait to get th gssproxy fix I've been developing today and set the minimum gssproxy version to the one with the fix once we get to publish it

"""

See the full comment at https://github.com/freeipa/freeipa/pull/559#issuecomment-286478736
simo5
2017-03-14 16:31:26 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Author: pvomacka
Title: #559: WebUI: Certificate login
Action: reopened

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/559/head:pr559
git checkout pr559
simo5
2017-03-14 16:31:47 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Title: #559: WebUI: Certificate login

Label: -ack
pvomacka
2017-03-14 17:04:42 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Title: #559: WebUI: Certificate login

pvomacka commented:
"""
Removed in https://github.com/freeipa/freeipa/pull/585 once it will be pushed I will close this one again.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/559#issuecomment-286490161
MartinBasti
2017-03-14 17:57:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Title: #559: WebUI: Certificate login

Label: +ack
MartinBasti
2017-03-14 17:58:03 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Author: pvomacka
Title: #559: WebUI: Certificate login
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/559/head:pr559
git checkout pr559
MartinBasti
2017-03-14 17:58:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/559
Title: #559: WebUI: Certificate login

MartinBasti commented:
"""
#585 was pushed
"""

See the full comment at https://github.com/freeipa/freeipa/pull/559#issuecomment-286507175
Loading...