Discussion:
[Freeipa-devel] [freeipa PR#591][opened] spec file: add unconditional python-setuptools BuildRequires
HonzaCholasta
2017-03-15 07:19:51 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/591
Author: HonzaCholasta
Title: #591: spec file: add unconditional python-setuptools BuildRequires
Action: opened

PR body:
"""
python-setuptools is required not only for lint, but to make the build
possible at all.

Move the python-setuptools BuildRequires from the lint section to the main
section.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/591/head:pr591
git checkout pr591
tiran
2017-03-15 07:31:13 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/591
Title: #591: spec file: add unconditional python-setuptools BuildRequires

Label: +ack
HonzaCholasta
2017-03-15 07:38:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/591
Title: #591: spec file: add unconditional python-setuptools BuildRequires

HonzaCholasta commented:
"""
master:

* 7ef4e9eb810063243fcc575434d856c854b14eee spec file: add unconditional python-setuptools BuildRequires
"""

See the full comment at https://github.com/freeipa/freeipa/pull/591#issuecomment-286663917
HonzaCholasta
2017-03-15 07:38:40 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/591
Author: HonzaCholasta
Title: #591: spec file: add unconditional python-setuptools BuildRequires
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/591/head:pr591
git checkout pr591
HonzaCholasta
2017-03-15 07:38:39 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/591
Title: #591: spec file: add unconditional python-setuptools BuildRequires

Label: +pushed
lslebodn
2017-03-15 09:23:29 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/591
Title: #591: spec file: add unconditional python-setuptools BuildRequires

lslebodn commented:
"""
Post push comment. This is a reason why there was configure time check in **rejected** PR#494.
Spec file change is not very upstream friendly.
https://github.com/freeipa/freeipa/pull/494/commits/a1321abbdb2cf510e0f36c65d2af0fb6329d2e23
"""

See the full comment at https://github.com/freeipa/freeipa/pull/591#issuecomment-286685603
Loading...