Discussion:
[Freeipa-devel] [freeipa PR#300][opened] WebUI: Add support for custom table pagination size
pvomacka
2016-12-02 09:32:43 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/300
Author: pvomacka
Title: #300: WebUI: Add support for custom table pagination size
Action: opened

PR body:
"""
New customization button opens dialog with field for setting the number of lines
in tables. After saving the new value there is new topic which starts refreshing
current table facet (if shown) and set all other facets expired. Therefore all
tables are immediately regenerated.

https://fedorahosted.org/freeipa/ticket/5742
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/300/head:pr300
git checkout pr300
pvomacka
2017-03-08 12:11:36 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/300
Author: pvomacka
Title: #300: WebUI: Add support for custom table pagination size
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/300/head:pr300
git checkout pr300
pvomacka
2017-03-08 12:12:07 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/300
Title: #300: WebUI: Add support for custom table pagination size

pvomacka commented:
"""
@pvoborni Thank you for review. Proposed changes fixed.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/300#issuecomment-285025154
pvoborni
2017-03-08 13:22:44 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/300
Title: #300: WebUI: Add support for custom table pagination size

Label: +ack
martbab
2017-03-08 13:55:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/300
Title: #300: WebUI: Add support for custom table pagination size

martbab commented:
"""
master:

* 7b699105a52d4d8c26a73044ba182d752b4a9833 Add javascript integer validator
* f78cc8932626de667c6e3a4461141a10a5d9c2e6 Make singleton from config module
* e1dfc51e48050ac1ad431d56003dc26e17ca653e Add support for custom table pagination size
"""

See the full comment at https://github.com/freeipa/freeipa/pull/300#issuecomment-285046345
martbab
2017-03-08 13:55:21 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/300
Author: pvomacka
Title: #300: WebUI: Add support for custom table pagination size
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/300/head:pr300
git checkout pr300
martbab
2017-03-08 13:55:16 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/300
Title: #300: WebUI: Add support for custom table pagination size

Label: +pushed

Loading...