Discussion:
[Freeipa-devel] [freeipa PR#754][opened] ipa-server-install with external CA: fix pkinit cert issuance
flo-renaud
2017-05-03 08:37:27 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/754
Author: flo-renaud
Title: #754: ipa-server-install with external CA: fix pkinit cert issuance
Action: opened

PR body:
"""
ipa-server-install with external CA fails to issue pkinit certs.
This happens because the installer calls
krb = krbinstance.KrbInstance(fstore)
then
krb.enable_ssl()
and in this code path self.config_pkinit is set to None, leading to a wrong
code path.

The fix initializes the required fields of the krbinstance before calling
krb.enable_ssl.

https://pagure.io/freeipa/issue/6921
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/754/head:pr754
git checkout pr754
stlaz
2017-05-03 08:43:24 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/754
Title: #754: ipa-server-install with external CA: fix pkinit cert issuance

stlaz commented:
"""
LGTM, will test it.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/754#issuecomment-298853939
stlaz
2017-05-03 10:50:32 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/754
Title: #754: ipa-server-install with external CA: fix pkinit cert issuance

Label: +ack
tomaskrizek
2017-05-03 14:29:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/754
Title: #754: ipa-server-install with external CA: fix pkinit cert issuance

Label: +pushed
tomaskrizek
2017-05-03 14:29:58 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/754
Title: #754: ipa-server-install with external CA: fix pkinit cert issuance

tomaskrizek commented:
"""
ipa-4-5:

* 8107125e177ac9f378d149d7b0fa1d3774c9be3a ipa-server-install with external CA: fix pkinit cert issuance


master:

* a24923066dd95a88ded329f1a558d46fbb9d8f81 ipa-server-install with external CA: fix pkinit cert issuance


"""

See the full comment at https://github.com/freeipa/freeipa/pull/754#issuecomment-298927858
tomaskrizek
2017-05-03 14:30:03 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/754
Author: flo-renaud
Title: #754: ipa-server-install with external CA: fix pkinit cert issuance
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/754/head:pr754
git checkout pr754

Loading...