Discussion:
[Freeipa-devel] [freeipa PR#654][opened] spec: update url and sources
tomaskrizek
2017-03-24 14:24:53 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/654
Author: tomaskrizek
Title: #654: spec: update url and sources
Action: opened

PR body:
"""
Point Source to upstream sources on pagure and add signature file.
Use https for project URL.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/654/head:pr654
git checkout pr654
MartinBasti
2017-03-24 14:45:47 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/654
Title: #654: spec: update url and sources

MartinBasti commented:
"""
LGTM
"""

See the full comment at https://github.com/freeipa/freeipa/pull/654#issuecomment-289042742
tomaskrizek
2017-03-24 15:48:21 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/654
Title: #654: spec: update url and sources

tomaskrizek commented:
"""
It looks like the build somehow depends on the specfile, because it fails with

```
error: Bad file: /home/sharp/git/freeipa/rpmbuild/SOURCES/freeipa-4.5.90.dev201703241540+gitcec2cfb.tar.gz.asc: No such file or directory
```

I guess we can omit this in upstream.

Fedora spec files have been updated and their build works fine.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/654#issuecomment-289061104
tomaskrizek
2017-03-24 15:48:17 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/654
Author: tomaskrizek
Title: #654: spec: update url and sources
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/654/head:pr654
git checkout pr654
tomaskrizek
2017-03-24 15:48:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/654
Title: #654: spec: update url and sources

Label: +rejected

Loading...