[Freeipa-devel] [freeipa PR#539][opened] Define errors_by_code in ipalib.errors

[frasertweedale]

URL: https://github.com/freeipa/freeipa/pull/539
Author: frasertweedale
Title: #539: Define errors_by_code in ipalib.errors
Action: opened

PR body:
"""
The errors_by_code mapping will soon be used in more places, as part
of the Dogtag GSS-API authentication work. Move its definition to
ipalib.errors.

Part of: https://pagure.io/freeipa/issue/5011
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/539/head:pr539
git checkout pr539

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/539
Title: #539: Define errors_by_code in ipalib.errors

HonzaCholasta commented:
"""
The codes are only relevant for XML-RPC. Why do you need them?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/539#issuecomment-284319912

[frasertweedale]

URL: https://github.com/freeipa/freeipa/pull/539
Title: #539: Define errors_by_code in ipalib.errors

frasertweedale commented:
"""
@HonzaCholasta when Dogtag execute the existing cert-request validation logic (which will be extracted to a new function), if an exception gets raised Dogtag returns it in the response, and IPA reconstructs it, so that there is no change to the user experience.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/539#issuecomment-284379517

[frasertweedale]

URL: https://github.com/freeipa/freeipa/pull/539
Title: #539: Define errors_by_code in ipalib.errors

frasertweedale commented:
"""
@HonzaCholasta when Dogtag execute the existing cert-request validation logic (which will be extracted to a new function), if an exception gets raised Dogtag returns it in the response, and IPA reconstructs it, so that there is no change to the user experience.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/539#issuecomment-284379517

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/539
Title: #539: Define errors_by_code in ipalib.errors

HonzaCholasta commented:
"""
Seems like an overkill for the ~2 types of errors which the code uses. Anyway, I would rather wait before making any kind of decision based on cert-request code until after it is refactored to be less insane (https://pagure.io/freeipa/issue/6531).
"""

See the full comment at https://github.com/freeipa/freeipa/pull/539#issuecomment-285261846

[frasertweedale]

URL: https://github.com/freeipa/freeipa/pull/539
Author: frasertweedale
Title: #539: Define errors_by_code in ipalib.errors
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/539/head:pr539
git checkout pr539

[frasertweedale]

URL: https://github.com/freeipa/freeipa/pull/539
Title: #539: Define errors_by_code in ipalib.errors

frasertweedale commented:
"""
Righto. I'll withdraw this PR for now and it will make a comeback closer to landing the gssapi work.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/539#issuecomment-285268049