[Freeipa-devel] [freeipa PR#535][comment] add whoami command

[abbra]

URL: https://github.com/freeipa/freeipa/pull/535
Title: #535: add whoami command

abbra commented:
"""
Design page: http://www.freeipa.org/page/V4/Who_Am_I_Command
"""

See the full comment at https://github.com/freeipa/freeipa/pull/535#issuecomment-283716554

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/535
Title: #535: add whoami command

stlaz commented:
"""
I believe that in CLI `ipa whoami` should actually output the output of the command it found with the arguments and options it found since in WebUI this is eventually done as well.
I can go ahead and try to implement it if we can agree on such behavior.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/535#issuecomment-285062912

[abbra]

URL: https://github.com/freeipa/freeipa/pull/535
Title: #535: add whoami command

abbra commented:
"""
Uhm, no, I don't want that. It makes the command behaving differently depending on a context and that would be broken. For client-side plugin that would also be an abuse of interface, I'd say.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/535#issuecomment-285063732

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/535
Title: #535: add whoami command

stlaz commented:
"""
Ok. It just doesn't seem right to have a command which shows something that's not immediately useful to the user. I am not sure whether we should have it enabled for CLI.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/535#issuecomment-285073261

[abbra]

URL: https://github.com/freeipa/freeipa/pull/535
Title: #535: add whoami command

abbra commented:
"""
We can disable it for CLI, that's not a problem.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/535#issuecomment-285085254

[abbra]

URL: https://github.com/freeipa/freeipa/pull/535
Author: abbra
Title: #535: add whoami command
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/535/head:pr535
git checkout pr535

[abbra]

URL: https://github.com/freeipa/freeipa/pull/535
Author: abbra
Title: #535: add whoami command
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/535/head:pr535
git checkout pr535

[abbra]

URL: https://github.com/freeipa/freeipa/pull/535
Title: #535: add whoami command

abbra commented:
"""
Updated.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/535#issuecomment-285310604

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/535
Title: #535: add whoami command

stlaz commented:
"""
@abbra Thank you for the changes, the patch seems fine now. I tested the user/service/host scenarios and it worked fine. I couldn't test idviews since trusts are broken now but I assume it should work fine as well.
If you could only apply the following patch https://transfer.sh/IA7Ic/0001-improve-one-more-dict.patch which improves the last `dict()` behavior then I'll bless this patch :)
We may want to add some tests later so I will propose to leave the ticket open.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/535#issuecomment-285336020

[abbra]

URL: https://github.com/freeipa/freeipa/pull/535
Author: abbra
Title: #535: add whoami command
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/535/head:pr535
git checkout pr535

[abbra]

URL: https://github.com/freeipa/freeipa/pull/535
Title: #535: add whoami command

abbra commented:
"""
Done. I've also updated the design page to reflect the changes.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/535#issuecomment-285340468

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/535
Title: #535: add whoami command

stlaz commented:
"""
Thank you, ACK. Please don't close the ticket, we still need tests.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/535#issuecomment-285344724

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/535
Title: #535: add whoami command

Label: +ack

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/535
Title: #535: add whoami command

MartinBasti commented:
"""
master:

* 381c1c7a8fe63526d21cb65decb75fb5ffda676a add whoami command
"""

See the full comment at https://github.com/freeipa/freeipa/pull/535#issuecomment-285347082

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/535
Author: abbra
Title: #535: add whoami command
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/535/head:pr535
git checkout pr535

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/535
Title: #535: add whoami command

Label: +pushed

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/535
Title: #535: add whoami command

MartinBasti commented:
"""
Tests: https://pagure.io/freeipa/issue/6745
"""

See the full comment at https://github.com/freeipa/freeipa/pull/535#issuecomment-285347687