[Freeipa-devel] [freeipa PR#671][opened] [WIP] Slim down dependencies

[tiran]

URL: https://github.com/freeipa/freeipa/pull/671
Author: tiran
Title: #671: [WIP] Slim down dependencies
Action: opened

PR body:
"""
* Remove unused install requires
* Correct dependencies for yubico otptoken
* Properly report optional dependency for yubico otptoken
* Make jinja2 an optional dependency and csrgen an optional plugin

Signed-off-by: Christian Heimes <***@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/671/head:pr671
git checkout pr671

[tiran]

URL: https://github.com/freeipa/freeipa/pull/671
Author: tiran
Title: #671: [WIP] Slim down dependencies
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/671/head:pr671
git checkout pr671

[tiran]

URL: https://github.com/freeipa/freeipa/pull/671
Author: tiran
Title: #671: Slim down dependencies
Action: edited

Changed field: title
Original value:
"""
[WIP] Slim down dependencies
"""

[tiran]

URL: https://github.com/freeipa/freeipa/pull/671
Author: tiran
Title: #671: Slim down dependencies
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/671/head:pr671
git checkout pr671

[tiran]

URL: https://github.com/freeipa/freeipa/pull/671
Author: tiran
Title: #671: Slim down dependencies
Action: edited

Changed field: body
Original value:
"""
* Remove unused install requires
* Correct dependencies for yubico otptoken
* Properly report optional dependency for yubico otptoken
* Make jinja2 an optional dependency and csrgen an optional plugin

Signed-off-by: Christian Heimes <***@redhat.com>
"""

[tiran]

URL: https://github.com/freeipa/freeipa/pull/671
Author: tiran
Title: #671: Slim down dependencies
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/671/head:pr671
git checkout pr671

[tiran]

URL: https://github.com/freeipa/freeipa/pull/671
Title: #671: Slim down dependencies

tiran commented:
"""
Now depends on PR #702
"""

See the full comment at https://github.com/freeipa/freeipa/pull/671#issuecomment-293195296

[tiran]

URL: https://github.com/freeipa/freeipa/pull/671
Author: tiran
Title: #671: Slim down dependencies
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/671/head:pr671
git checkout pr671

[tiran]

URL: https://github.com/freeipa/freeipa/pull/671
Author: tiran
Title: #671: Slim down dependencies
Action: edited

Changed field: body
Original value:
"""
* Remove unused install requires
* Correct dependencies for yubico otptoken
* Properly report optional dependency for yubico otptoken
* Make jinja2 an optional dependency and csrgen an optional plugin
* Add explicit dependency on cffi for csrgen
* Python 2 uses python-ldap, Python 3 pyldap

Signed-off-by: Christian Heimes <***@redhat.com>
"""

[tiran]

URL: https://github.com/freeipa/freeipa/pull/671
Author: tiran
Title: #671: Slim down dependencies
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/671/head:pr671
git checkout pr671

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/671
Title: #671: Slim down dependencies

MartinBasti commented:
"""
Due missing jinja, tox tests failed

```
ERROR: py27: commands failed
ERROR: py35: commands failed
ERROR: py36: commands failed
ERROR: pylint2: commands failed
ERROR: pylint3: commands failed
```

Tests
```
ImportError while importing test module '/tmp/freeipa/.tox/py36/lib/python3.6/site-packages/ipatests/test_ipaclient/test_csrgen.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test_ipaclient/test_csrgen.py:8: in <module>
from ipaclient import csrgen
../ipaclient/csrgen.py:23: in <module>
import jinja2
E ModuleNotFoundError: No module named 'jinja2'

```

pylint
```
************* Module ipaclient.csrgen
lib/python3.5/site-packages/ipaclient/csrgen.py:23: [E0401(import-error), ] Unable to import 'jinja2')
lib/python3.5/site-packages/ipaclient/csrgen.py:24: [E0401(import-error), ] Unable to import 'jinja2.ext')
lib/python3.5/site-packages/ipaclient/csrgen.py:25: [E0401(import-error), ] Unable to import 'jinja2.sandbox')
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/671#issuecomment-298675008

[tiran]

URL: https://github.com/freeipa/freeipa/pull/671
Author: tiran
Title: #671: Slim down dependencies
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/671/head:pr671
git checkout pr671

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/671
Title: #671: Slim down dependencies

Label: +ack

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/671
Title: #671: Slim down dependencies

Label: +pushed

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/671
Title: #671: Slim down dependencies

MartinBasti commented:
"""
master:

* bd5a5012d24820b54cdca2955f5405b84de1178c Slim down dependencies


"""

See the full comment at https://github.com/freeipa/freeipa/pull/671#issuecomment-300198093

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/671
Author: tiran
Title: #671: Slim down dependencies
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/671/head:pr671
git checkout pr671