Discussion:
[Freeipa-devel] [freeipa PR#738][opened] restore: restart gssproxy after restore
pvoborni
2017-04-26 17:08:03 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/738
Author: pvoborni
Title: #738: restore: restart gssproxy after restore
Action: opened

PR body:
"""
So that gssproxy picks up new configuration and therefore related
usages like authentication of CLI against server works

https://pagure.io/freeipa/issue/6902

@simo5 btw, what is the proper name of gssproxy? Is it GSSAPI proxy, gss-proxy or gssproxy?

Note: if this patch is wrong, feel free to take over and abolish this PR.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/738/head:pr738
git checkout pr738
simo5
2017-04-26 17:31:56 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/738
Title: #738: restore: restart gssproxy after restore

simo5 commented:
"""
The name of the project is GSS-Proxy, the package name is gssproxy.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/738#issuecomment-297484796
simo5
2017-04-26 21:15:33 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/738
Title: #738: restore: restart gssproxy after restore

simo5 commented:
"""
will a "systemctl reload gssproxy" do the right thing @frozencemetery ?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/738#issuecomment-297543414
frozencemetery
2017-04-27 00:49:19 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/738
Title: #738: restore: restart gssproxy after restore

frozencemetery commented:
"""
The systemd-portable way to do this is as I understand it is `systemctl try-reload-or-restart gssproxy` (unless you want to start it if it's not running, at which point you'd do `systemctl reload-or-restart gssproxy`). Then you're not dependent on how the distro maintainer decides to handle it (which varies between distros here due to reasons).

That is something of an orthogonal consideration though - digging further into the code, it doesn't look like there's a `reload`-style verb of any kind in the services abstraction layer? (I see `is_running()` and `restart()`, but no `reload()` in services.py.) I don't know how you want to address this; whether it makes sense to extend the abstraction, or whether since no one else uses it gssproxy can just be `restart`ed.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/738#issuecomment-297580677
pvoborni
2017-04-28 10:16:22 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/738
Title: #738: restore: restart gssproxy after restore

pvoborni commented:
"""
PR #748 obsoletes this one - this PR was created badly and so I cannot force update it. New one uses reload-or-restart
"""

See the full comment at https://github.com/freeipa/freeipa/pull/738#issuecomment-297962651
pvoborni
2017-04-28 10:16:26 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/738
Author: pvoborni
Title: #738: restore: restart gssproxy after restore
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/738/head:pr738
git checkout pr738
pvoborni
2017-04-28 10:16:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/738
Title: #738: restore: restart gssproxy after restore

Label: +rejected

Loading...