Discussion:
[Freeipa-devel] [freeipa PR#728][opened] ipa-cacert-manage: add --external-ca-type
HonzaCholasta
2017-04-24 15:39:29 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/728
Author: HonzaCholasta
Title: #728: ipa-cacert-manage: add --external-ca-type
Action: opened

PR body:
"""
**server upgrade: always fix certmonger tracking request**

Fix certmonger tracking requests on every run of ipa-server-upgrade rather
than only when the tracking configuration has changed and the requests have
not yet been updated.

This allows fixing broken tracking requests just by re-running
ipa-server-upgrade.

**cainstance: use correct profile for lightweight CA certificates**

Use Dogtag's `caCACert` CA certificate profile rather than the
`ipaCACertRenewal` virtual profile for lightweight CA certificates.

The `ipaCACertRenewal` virtual profile adds special handling of externally
signed CA certificates and LDAP replication of issued certificates on top
of `caCACert`, neither of which is relevant for lightweight CA
certificates.

Remove all of the special casing of lightweight CA certificates from
dogtag-ipa-ca-renew-agent-submit.

Make sure existing lightweight CA certmonger tracking requests are updated
on server upgrade.

**renew agent: allow reusing existing certs**

Add a switch which makes `dogtag-ipa-ca-renew-agent-submit` reuse the
existing certificate rather than request a new one from the CA while
maintaining LDAP replication of the certificate.

Make this available as a new `dogtag-ipa-ca-renew-agent-reuse` certmonger
CA.

This allows redoing the LDAP replication and reexecuting pre- and post-save
commands of a tracking request without reissuing the certificate.

**renew agent: always export CSR on IPA CA certificate renewal**

Make sure a CSR is exported for the IPA CA whenever certmonger detects that
the CA certificate is about to expire.

This is a pre-requisite for using the `dogtag-ipa-ca-renew-agent-reuse` CA
instead of the `ipaCSRExport` virtual profile to export the CSR.

**renew agent: get rid of virtual profiles**

Replace all uses of virtual profiles with `dogtag-ipa-ca-renew-agent-reuse`
and remove profile from the IPA CA certificate tracking request.

This prevents virtual profiles from making their way into CSRs and in turn
being rejected by certain CAs. This affected the IPA CA CSR with Microsoft
CS in particular.

**ipa-cacert-manage: add --external-ca-type**

Add the `--external-ca-type`, as known from `ipa-server-install` and
`ipa-ca-install`, to `ipa-cacert-manage`.

This allows creating IPA CA CSRs suitable for use with Microsoft CS using
`ipa-cacert-manage`:

```
ipa-cacert-manage renew --external-ca --external-ca-type=ms-cs
```

https://pagure.io/freeipa/issue/5799
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/728/head:pr728
git checkout pr728
HonzaCholasta
2017-05-03 07:53:05 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/728
Author: HonzaCholasta
Title: #728: ipa-cacert-manage: add --external-ca-type
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/728/head:pr728
git checkout pr728
HonzaCholasta
2017-05-09 06:12:56 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/728
Author: HonzaCholasta
Title: #728: ipa-cacert-manage: add --external-ca-type
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/728/head:pr728
git checkout pr728
stlaz
2017-05-12 10:36:48 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/728
Title: #728: ipa-cacert-manage: add --external-ca-type

stlaz commented:
"""
LGTM
"""

See the full comment at https://github.com/freeipa/freeipa/pull/728#issuecomment-301043646
dkupka
2017-05-12 10:53:58 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/728
Title: #728: ipa-cacert-manage: add --external-ca-type

dkupka commented:
"""
Work for me.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/728#issuecomment-301046744
dkupka
2017-05-12 10:54:07 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/728
Title: #728: ipa-cacert-manage: add --external-ca-type

Label: +ack
dkupka
2017-05-15 10:20:57 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/728
Title: #728: ipa-cacert-manage: add --external-ca-type

Label: +pushed
dkupka
2017-05-15 10:21:00 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/728
Title: #728: ipa-cacert-manage: add --external-ca-type

dkupka commented:
"""
master:

* ce9eefe53b398b73f956df420ea8694b90e24f76 renew agent: respect CA renewal master setting
* 5abd9bb99680df45b6cd87de3b08466d612344bb server upgrade: always fix certmonger tracking request
* 09a49ad45846e3c2e76c5a035a27d0fa95b347b9 cainstance: use correct profile for lightweight CA certificates
* 25aeeaf46dd92e06f14de83459ab9be8ab846922 renew agent: allow reusing existing certs
* 0bf41e804e89937fc72502cfbe1363dd7591675e renew agent: always export CSR on IPA CA certificate renewal
* 21f4cbf8da8091b898fc8032fff65e821223d042 renew agent: get rid of virtual profiles
* b03ede87963bc5933691c9e3f88768e1bf92736f ipa-cacert-manage: add --external-ca-type
ipa-4-5:

* 36fc44b90ceb9e98abd93a3abb1e5b8d18df6ff0 renew agent: respect CA renewal master setting
* b55dd9cee5c2161002f56c63d7e0ae86e792fbbd server upgrade: always fix certmonger tracking request
* 4a01114f1e49fd73e88e2d9f1512a11cbab0176e cainstance: use correct profile for lightweight CA certificates
* 920d56a8f0321c4b092da6c173961c82aa1d6bd3 renew agent: allow reusing existing certs
* 25b0a9cf6c60c709cacb74ad188cd6e91d4b60ea renew agent: always export CSR on IPA CA certificate renewal
* bb952827b84d7b47ffd77549b3a7c9da2fe537ae renew agent: get rid of virtual profiles
* c56d12aeaccb455a193271a31362b7412b2d2e60 ipa-cacert-manage: add --external-ca-type
"""

See the full comment at https://github.com/freeipa/freeipa/pull/728#issuecomment-301435675
dkupka
2017-05-15 10:21:03 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/728
Author: HonzaCholasta
Title: #728: ipa-cacert-manage: add --external-ca-type
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/728/head:pr728
git checkout pr728

Loading...