Discussion:
[Freeipa-devel] [freeipa PR#669][opened] server: make sure we test for sss_nss_getlistbycert
abbra
2017-03-29 07:44:44 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/669
Author: abbra
Title: #669: server: make sure we test for sss_nss_getlistbycert
Action: opened

PR body:
"""
Fixes https://pagure.io/freeipa/issue/6828
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/669/head:pr669
git checkout pr669
tiran
2017-03-29 07:50:50 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/669
Title: #669: server: make sure we test for sss_nss_getlistbycert

tiran commented:
"""
AC_CHECK_LIB only checks for functions in libs. Compilation may still fail if header files and library are not in sync. IMHO we don't have to care about this broken case.

LGTM
"""

See the full comment at https://github.com/freeipa/freeipa/pull/669#issuecomment-290011518
abbra
2017-03-29 08:11:15 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/669
Title: #669: server: make sure we test for sss_nss_getlistbycert

abbra commented:
"""
On the systems where pkg-config is available, positive result from pkg-config check means headers are available because pkg-config files are part of development sub-packages. Symbol check in a library is enough then.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/669#issuecomment-290016098
tomaskrizek
2017-03-29 08:26:14 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/669
Title: #669: server: make sure we test for sss_nss_getlistbycert

tomaskrizek commented:
"""
Works as expected.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/669#issuecomment-290019629
tomaskrizek
2017-03-29 08:26:19 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/669
Title: #669: server: make sure we test for sss_nss_getlistbycert

Label: +ack
tomaskrizek
2017-03-29 08:35:51 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/669
Title: #669: server: make sure we test for sss_nss_getlistbycert

Label: +pushed
tomaskrizek
2017-03-29 08:35:57 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/669
Author: abbra
Title: #669: server: make sure we test for sss_nss_getlistbycert
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/669/head:pr669
git checkout pr669
tomaskrizek
2017-03-29 08:35:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/669
Title: #669: server: make sure we test for sss_nss_getlistbycert

tomaskrizek commented:
"""
master:

* 67e5244cad72bef76de1c4df47a0c77a672fa861 server: make sure we test for sss_nss_getlistbycert
ipa-4-5:

* 8be6987da72dff0ebd4e02c946b45b5b1705d880 server: make sure we test for sss_nss_getlistbycert
"""

See the full comment at https://github.com/freeipa/freeipa/pull/669#issuecomment-290022005
Loading...