[Freeipa-devel] [freeipa PR#757][opened] ca, kra install: validate DM password

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/757
Author: tomaskrizek
Title: #757: ca, kra install: validate DM password
Action: opened

PR body:
"""
Prevent CA and KRA installation from proceeding if provided DM password is invalid to avoid broken installations with no possibility to uninstall CA or KRA.

https://pagure.io/freeipa/issue/6892
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/757/head:pr757
git checkout pr757

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/757
Author: tomaskrizek
Title: #757: ca, kra install: validate DM password
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/757/head:pr757
git checkout pr757

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/757
Title: #757: ca, kra install: validate DM password

stlaz commented:
"""
There will be no more sys.exits. This patchset shall not be ACKed until all have been removed.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/757#issuecomment-299111113

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/757
Author: tomaskrizek
Title: #757: ca, kra install: validate DM password
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/757/head:pr757
git checkout pr757

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/757
Title: #757: ca, kra install: validate DM password

tomaskrizek commented:
"""
Thanks for the feedback, hopefully I addressed all the issues.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/757#issuecomment-299469642

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/757
Author: tomaskrizek
Title: #757: ca, kra install: validate DM password
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/757/head:pr757
git checkout pr757

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/757
Author: tomaskrizek
Title: #757: ca, kra install: validate DM password
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/757/head:pr757
git checkout pr757

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/757
Title: #757: ca, kra install: validate DM password

tomaskrizek commented:
"""
Implementing the tests shouldn't block us from pushing this fix. I opened a ticket for it: https://pagure.io/freeipa/issue/6941
"""

See the full comment at https://github.com/freeipa/freeipa/pull/757#issuecomment-300514130

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/757
Title: #757: ca, kra install: validate DM password

MartinBasti commented:
"""
We have to use `sys.exit()` in this case, because I forgot that CA still uses old style installer. Without `sys.exit()` ti will always suggest user to uninstall server:

```
Your system may be partly configured.
Run /usr/sbin/ipa-server-install --uninstall to clean up.
```

We don't want to uninstall server due typo in password
"""

See the full comment at https://github.com/freeipa/freeipa/pull/757#issuecomment-300811680

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/757
Author: tomaskrizek
Title: #757: ca, kra install: validate DM password
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/757/head:pr757
git checkout pr757

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/757
Author: tomaskrizek
Title: #757: ca, kra install: validate DM password
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/757/head:pr757
git checkout pr757

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/757
Title: #757: ca, kra install: validate DM password

stlaz commented:
"""
You forgot an import in ipa-ca-install:
```
************* Module ipa-ca-install

install/tools/ipa-ca-install:37: [W0611(unused-import), ] Unused ScriptError imported from ipapython.admintool)
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/757#issuecomment-301058163

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/757
Author: tomaskrizek
Title: #757: ca, kra install: validate DM password
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/757/head:pr757
git checkout pr757