[Freeipa-devel] [bind-dyndb-ldap PR#16][opened] spec: remove unnecessary bind-pkcs11 dependency

[tomaskrizek]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/16
Author: tomaskrizek
Title: #16: spec: remove unnecessary bind-pkcs11 dependency
Action: opened

PR body:
"""
The bind-pkcs11 dependency was originally introduced in Fedora
specfile in 2014 to help with ipa-server-upgrade. This was a
temporary workaround. Since Fedora life cycle is 13 months and
this change happened more than two years ago, it is safe to
remove the workaround.

bind-dyndb-ldap does not actually depend on bind-pkcs11, although it
is a dependency that is enforced by freeipa.
"""

To pull the PR as Git branch:
git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap
git fetch ghbind-dyndb-ldap pull/16/head:pr16
git checkout pr16

[MartinBasti]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/16
Title: #16: spec: remove unnecessary bind-pkcs11 dependency

MartinBasti commented:
"""
LGTM
"""

See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/16#issuecomment-292500650

[tomaskrizek]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/16
Title: #16: spec: remove unnecessary bind-pkcs11 dependency

Label: +ack

[tomaskrizek]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/16
Title: #16: spec: remove unnecessary bind-pkcs11 dependency

tomaskrizek commented:
"""
master:
- 4fb51bac7f4f739975a2afb857b686869eff92b6
"""

See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/16#issuecomment-292502794

[tomaskrizek]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/16
Author: tomaskrizek
Title: #16: spec: remove unnecessary bind-pkcs11 dependency
Action: closed

To pull the PR as Git branch:
git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap
git fetch ghbind-dyndb-ldap pull/16/head:pr16
git checkout pr16

[tomaskrizek]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/16
Title: #16: spec: remove unnecessary bind-pkcs11 dependency

Label: +pushed

[lslebodn]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/16
Title: #16: spec: remove unnecessary bind-pkcs11 dependency

lslebodn commented:
"""
I am not sure whether change to "requires" is ideal. Because after installation of freeipa-dns with this spec file system will contain packages: `bind` and `bind-pkcs11`. And I doubt both will be running in the same time.

rpm 4.13 is in fedora 24+ and contains boolean dependencies
http://rpm.org/user_doc/more_dependencies.html#boolean-dependencies
"""

See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/16#issuecomment-292711267

[tomaskrizek]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/16
Title: #16: spec: remove unnecessary bind-pkcs11 dependency

tomaskrizek commented:
"""
@lslebodn The boolean dependencies look interesting. That seems like a better way to handle this `bind` / `bind-pkcs11` issue. I'll take a look at it.
"""

See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/16#issuecomment-292745388

[MartinBasti]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/16
Title: #16: spec: remove unnecessary bind-pkcs11 dependency

MartinBasti commented:
"""
@lslebodn `bind-pkcs11` requires `bind` package
"""

See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/16#issuecomment-292868635