Discussion:
[Freeipa-devel] [freeipa PR#695][opened] Fix PKCS11 helper
MartinBasti
2017-04-05 19:10:22 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/695
Author: MartinBasti
Title: #695: Fix PKCS11 helper
Action: opened

PR body:
"""
Slots in HSM are not assigned statically, we have to chose proper
slot from token label.

Softhsm i2.2.0 changed this behavior and now slots can change over
time (it is allowed by pkcs11 standard).

Changelog:
* created method get_slot() that returns slot number from
used label
* replaces usage of slot in __init__ method of P11_Helper
with label
* slot is dynamically detected from token label before
session is opened
* pkcs11-util --init-token now uses '--free' instead '--slot'
which uses first free slot (we don't care about slot numbers
anymore)

https://pagure.io/freeipa/issue/6692
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/695/head:pr695
git checkout pr695
MartinBasti
2017-04-05 19:10:32 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/695
Author: MartinBasti
Title: #695: [4.4] Fix PKCS11 helper
Action: edited

Changed field: title
Original value:
"""
Fix PKCS11 helper
"""
MartinBasti
2017-04-05 19:16:25 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/695
Author: MartinBasti
Title: #695: [4.4] Fix PKCS11 helper
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/695/head:pr695
git checkout pr695
stlaz
2017-04-11 14:19:26 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/695
Title: #695: [4.4] Fix PKCS11 helper

Label: +ack
MartinBasti
2017-04-12 07:53:43 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/695
Title: #695: [4.4] Fix PKCS11 helper

Label: +pushed
MartinBasti
2017-04-12 07:53:49 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/695
Author: MartinBasti
Title: #695: [4.4] Fix PKCS11 helper
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/695/head:pr695
git checkout pr695
MartinBasti
2017-04-12 07:53:46 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/695
Title: #695: [4.4] Fix PKCS11 helper

MartinBasti commented:
"""
ipa-4-4:

* 07df61b7814db08d81e1ff92f58b24e5d852fdf8 Fix PKCS11 helper


"""

See the full comment at https://github.com/freeipa/freeipa/pull/695#issuecomment-293501844
Loading...