Discussion:
[Freeipa-devel] [freeipa PR#560][opened] rpcserver: x509_login: Handle unsuccessful certificate login gracefully
dkupka
2017-03-09 11:52:35 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/560
Author: dkupka
Title: #560: rpcserver: x509_login: Handle unsuccessful certificate login gracefully
Action: opened

PR body:
"""
When mod_lookup_identity is unable to match user by certificate (and username)
it unsets http request's user. mod_auth_gssapi is then unable to get Kerberos
ticket and doesn't set KRB5CCNAME environment variable.
x509_login.__call__ now returns 401 in such case to indicate that request was
not authenticated.

https://pagure.io/freeipa/issue/6225
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/560/head:pr560
git checkout pr560
dkupka
2017-03-14 13:42:15 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/560
Author: dkupka
Title: #560: rpcserver: x509_login: Handle unsuccessful certificate login gracefully
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/560/head:pr560
git checkout pr560
flo-renaud
2017-03-15 09:33:14 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/560
Title: #560: rpcserver: x509_login: Handle unsuccessful certificate login gracefully

Label: +ack
flo-renaud
2017-03-15 09:33:25 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/560
Title: #560: rpcserver: x509_login: Handle unsuccessful certificate login gracefully

flo-renaud commented:
"""
Hi,
the invalid cert login correctly returns 401.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/560#issuecomment-286688068
MartinBasti
2017-03-15 09:35:11 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/560
Title: #560: rpcserver: x509_login: Handle unsuccessful certificate login gracefully

Label: +pushed
MartinBasti
2017-03-15 09:35:14 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/560
Title: #560: rpcserver: x509_login: Handle unsuccessful certificate login gracefully

MartinBasti commented:
"""
master:

* 70889d4d5e7e2bd65ab1d4a28e5eda4a51c9b0c0 rpcserver: x509_login: Handle unsuccessful certificate login gracefully
"""

See the full comment at https://github.com/freeipa/freeipa/pull/560#issuecomment-286688582
MartinBasti
2017-03-15 09:35:12 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/560
Author: dkupka
Title: #560: rpcserver: x509_login: Handle unsuccessful certificate login gracefully
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/560/head:pr560
git checkout pr560

Loading...