Discussion:
[Freeipa-devel] [freeipa PR#553][opened] Add check for removing last KRA server
stlaz
2017-03-08 12:11:10 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Author: stlaz
Title: #553: Add check for removing last KRA server
Action: opened

PR body:
"""
This patchset adds a check for removal of a last KRA server + adds a message about there only being one KRA to WebUI.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/553/head:pr553
git checkout pr553
stlaz
2017-03-08 12:51:19 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Title: #553: Add check for removing last KRA server

stlaz commented:
"""
Hm, I forgot that KRA is the only IPA component that has a standalone uninstaller, this is therefore only a partial fix.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/553#issuecomment-285032496
MartinBasti
2017-03-08 12:54:44 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Title: #553: Add check for removing last KRA server

MartinBasti commented:
"""
@stlaz I wrote it to ticket
"""

See the full comment at https://github.com/freeipa/freeipa/pull/553#issuecomment-285033127
stlaz
2017-03-08 13:48:32 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Author: stlaz
Title: #553: Add check for removing last KRA server
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/553/head:pr553
git checkout pr553
stlaz
2017-03-08 13:49:06 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Title: #553: Add check for removing last KRA server

stlaz commented:
"""
@MartinBasti ah, sorry, I completely overlooked it. The current PR version implements your suggestion.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/553#issuecomment-285044830
MartinBasti
2017-03-08 14:11:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Title: #553: Add check for removing last KRA server

MartinBasti commented:
"""
Please create a separate commit for KRA Uninstall
"""

See the full comment at https://github.com/freeipa/freeipa/pull/553#issuecomment-285050412
stlaz
2017-03-08 15:44:03 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Author: stlaz
Title: #553: Add check for removing last KRA server
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/553/head:pr553
git checkout pr553
stlaz
2017-03-08 15:44:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Title: #553: Add check for removing last KRA server

stlaz commented:
"""
Split done.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/553#issuecomment-285077007
MartinBasti
2017-03-08 16:39:39 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Title: #553: Add check for removing last KRA server

MartinBasti commented:
"""
JFTR: KRA uninstall commit is here #556
"""

See the full comment at https://github.com/freeipa/freeipa/pull/553#issuecomment-285093976
MartinBasti
2017-03-08 17:55:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Title: #553: Add check for removing last KRA server

MartinBasti commented:
"""
Probably you we should fix this before we double number of alerts
https://pagure.io/freeipa/issue/6598
"""

See the full comment at https://github.com/freeipa/freeipa/pull/553#issuecomment-285116330
pvoborni
2017-03-09 19:14:55 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Title: #553: Add check for removing last KRA server

pvoborni commented:
"""
Fix for 6598 in #566
"""

See the full comment at https://github.com/freeipa/freeipa/pull/553#issuecomment-285450624
stlaz
2017-03-10 11:33:28 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Author: stlaz
Title: #553: Add check for removing last KRA server
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/553/head:pr553
git checkout pr553
stlaz
2017-03-10 11:34:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Title: #553: Add check for removing last KRA server

stlaz commented:
"""
Reworked how the beg for a service replication worked.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/553#issuecomment-285647389
stlaz
2017-03-10 11:51:16 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Author: stlaz
Title: #553: Add check for removing last KRA server
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/553/head:pr553
git checkout pr553
MartinBasti
2017-03-13 10:57:49 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Title: #553: Add check for removing last KRA server

Label: +ack
MartinBasti
2017-03-13 15:11:11 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Title: #553: Add check for removing last KRA server

MartinBasti commented:
"""
master:

* 670f8fb1db109ec2c9ab7e5d2189325988220b23 Add check to prevent removal of last KRA
* 1e8db4b5c7a55dac0008ad9b9bf5802ba30e8c2a Add message about last KRA to WebUI Topology view
"""

See the full comment at https://github.com/freeipa/freeipa/pull/553#issuecomment-286136808
MartinBasti
2017-03-13 15:11:12 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Author: stlaz
Title: #553: Add check for removing last KRA server
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/553/head:pr553
git checkout pr553
MartinBasti
2017-03-13 15:11:09 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/553
Title: #553: Add check for removing last KRA server

Label: +pushed

Loading...