Discussion:
[Freeipa-devel] [freeipa PR#786][opened] ipa-server-install: fix uninstall
flo-renaud
2017-05-15 15:18:39 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/786
Author: flo-renaud
Title: #786: ipa-server-install: fix uninstall
Action: opened

PR body:
"""
ipa-server-install --uninstall fails to stop tracking the certificates
because it assigns a tuple to the variable nicknames, then tries to
call nicknames.append(). This is a regression introduced by 92a08266.

Assignment should be done using nicknames = list(self.tracking_reqs) instead.

https://pagure.io/freeipa/issue/6950
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/786/head:pr786
git checkout pr786
flo-renaud
2017-05-16 11:02:48 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/786
Author: flo-renaud
Title: #786: ipa-server-install: fix uninstall
Action: edited

Changed field: body
Original value:
"""
ipa-server-install --uninstall fails to stop tracking the certificates
because it assigns a tuple to the variable nicknames, then tries to
call nicknames.append(). This is a regression introduced by 92a08266.

Assignment should be done using nicknames = list(self.tracking_reqs) instead.

https://pagure.io/freeipa/issue/6950
"""
flo-renaud
2017-05-16 11:03:29 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/786
Author: flo-renaud
Title: #786: ipa-server-install: fix uninstall
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/786/head:pr786
git checkout pr786
HonzaCholasta
2017-05-16 11:33:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/786
Title: #786: ipa-server-install: fix uninstall

Label: +ack
HonzaCholasta
2017-05-16 11:44:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/786
Title: #786: ipa-server-install: fix uninstall

Label: +pushed
HonzaCholasta
2017-05-16 11:44:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/786
Title: #786: ipa-server-install: fix uninstall

HonzaCholasta commented:
"""
master:

* d9ed2573fd5b4dcdc8ea865f16d81325707e0f9d ipa-server-install: fix uninstall


ipa-4-5:

* 752e167497eca87632261dec7bbb352cd0e599c8 ipa-server-install: fix uninstall


"""

See the full comment at https://github.com/freeipa/freeipa/pull/786#issuecomment-301756756
HonzaCholasta
2017-05-16 11:44:46 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/786
Author: flo-renaud
Title: #786: ipa-server-install: fix uninstall
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/786/head:pr786
git checkout pr786

Loading...