Discussion:
[Freeipa-devel] [freeipa PR#652][opened]
flo-renaud
2017-03-24 10:53:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/652
Author: flo-renaud
Title: #652: dogtag-ipa-ca-renew-agent-submit: fix the is_replicated() function
Action: opened

PR body:
"""
dogtag-ipa-ca-renew-agent-submit behaves differently depending on the
certificate it needs to renew. For instance, some certificates (such as IPA RA)
are the same on all the hosts and the renewal is actually done only on
the renewal master. On other nodes, the new cert is downloaded from LDAP.

The function is_replicated() is returning the opposite as what it should. If
the cert nickname is IPA RA, it should return that the cert is replicated but
it doesn't, and this leads to a wrong code path to renew the cert.

https://pagure.io/freeipa/issue/6813
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/652/head:pr652
git checkout pr652
HonzaCholasta
2017-03-28 07:01:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/652
Title: #652: dogtag-ipa-ca-renew-agent-submit: fix the is_replicated() function

Label: +ack
HonzaCholasta
2017-03-28 07:02:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/652
Title: #652: dogtag-ipa-ca-renew-agent-submit: fix the is_replicated() function

Label: +pushed
HonzaCholasta
2017-03-28 07:02:37 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/652
Author: flo-renaud
Title: #652: dogtag-ipa-ca-renew-agent-submit: fix the is_replicated() function
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/652/head:pr652
git checkout pr652
HonzaCholasta
2017-03-28 07:02:40 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/652
Title: #652: dogtag-ipa-ca-renew-agent-submit: fix the is_replicated() function

HonzaCholasta commented:
"""
master:

* e934da09d5e738c735f874931dd1b54d79b3150b dogtag-ipa-ca-renew-agent-submit: fix the is_replicated() function
ipa-4-5:

* 8f738f1ea9f86a921e3dc0fd02e57419f3173ed9 dogtag-ipa-ca-renew-agent-submit: fix the is_replicated() function
"""

See the full comment at https://github.com/freeipa/freeipa/pull/652#issuecomment-289681810
Loading...