Discussion:
[Freeipa-devel] [freeipa PR#644][opened] extdom: improve certificate request
sumit-bose
2017-03-23 09:35:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/644
Author: sumit-bose
Title: #644: extdom: improve certificate request
Action: opened

PR body:
"""
Certificates can be assigned to multiple user so the extdom plugin must use
sss_nss_getlistbycert() instead of sss_nss_getnamebycert() and return a
list of fully-qualified user names.

Due to issues on the SSSD side the current version of lookups by
certificates didn't work at all and the changes here won't break existing
clients.

Related to https://pagure.io/freeipa/issue/6646

Since I used the revers lookup for the domain separator in patch I added a
second patch which does this where needed in the reminder of the code as well
to be consistent. Allthough using @-signs in short names is not common practice
it might happen as can be see in https://pagure.io/SSSD/sssd/issue/3219.

The sss_nss_getlistbycert() call is added to SSSD in
https://github.com/SSSD/sssd/pull/207.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/644/head:pr644
git checkout pr644
abbra
2017-03-23 10:05:25 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/644
Title: #644: extdom: improve certificate request

abbra commented:
"""
LGTM. I read the code but since SSSD counterpart is currently on review, travis fails the build.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/644#issuecomment-288671714
sumit-bose
2017-03-24 18:54:24 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/644
Author: sumit-bose
Title: #644: extdom: improve certificate request
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/644/head:pr644
git checkout pr644
sumit-bose
2017-03-27 06:39:05 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/644
Author: sumit-bose
Title: #644: extdom: improve certificate request
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/644/head:pr644
git checkout pr644
sumit-bose
2017-03-27 07:23:25 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/644
Author: sumit-bose
Title: #644: extdom: improve certificate request
Action: reopened

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/644/head:pr644
git checkout pr644
sumit-bose
2017-03-27 07:23:21 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/644
Author: sumit-bose
Title: #644: extdom: improve certificate request
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/644/head:pr644
git checkout pr644
dkupka
2017-03-28 13:12:28 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/644
Title: #644: extdom: improve certificate request

dkupka commented:
"""
Works for me.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/644#issuecomment-289764835
dkupka
2017-03-28 13:12:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/644
Title: #644: extdom: improve certificate request

Label: +ack
sumit-bose
2017-03-28 16:19:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/644
Author: sumit-bose
Title: #644: extdom: improve certificate request
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/644/head:pr644
git checkout pr644
tomaskrizek
2017-03-28 16:22:45 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/644
Author: sumit-bose
Title: #644: extdom: improve certificate request
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/644/head:pr644
git checkout pr644
tomaskrizek
2017-03-28 16:22:43 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/644
Title: #644: extdom: improve certificate request

tomaskrizek commented:
"""
master:

* ee455f163d756a6b71db8e999365139cad46c6ad extdom: do reverse search for domain separator
* 8960398a57f69c124ec3105289dc355baa0d5b09 extdom: improve cert request
ipa-4-5:

* 8046f9baab1e93b8b8e11d05088c8cdabdd47281 extdom: do reverse search for domain separator
* a510a3d7e9f37e89acee84bed2363cb7f57fe88e extdom: improve cert request
"""

See the full comment at https://github.com/freeipa/freeipa/pull/644#issuecomment-289824801
tomaskrizek
2017-03-28 16:22:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/644
Title: #644: extdom: improve certificate request

Label: +pushed

Loading...