Discussion:
[Freeipa-devel] [freeipa PR#761][opened] Fixing adding authenticator indicators to host
felipevolpone
2017-05-03 17:27:22 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/761
Author: felipevolpone
Title: #761: Fixing adding authenticator indicators to host
Action: opened

PR body:
"""
The check for krbprincipalaux in the entries is now made case-insensitively.

https://pagure.io/freeipa/issue/6911
https://bugzilla.redhat.com/show_bug.cgi?id=1441593#c2
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/761/head:pr761
git checkout pr761
stlaz
2017-05-04 06:15:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/761
Title: #761: Fixing adding authenticator indicators to host

stlaz commented:
"""
```
************* Module ipaserver.plugins.host

ipaserver/plugins/host.py:887: [C0303(trailing-whitespace), ] Trailing whitespace)
```
\+ wrong author in the commit
"""

See the full comment at https://github.com/freeipa/freeipa/pull/761#issuecomment-299104113
pvoborni
2017-05-04 12:35:09 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/761
Title: #761: Fixing adding authenticator indicators to host

pvoborni commented:
"""
I'd fix it on all places in host-mod:
```
885 raise errors.ACIError(info=msg)
886 obj_classes = entry_attrs_old['objectclass']
887: if 'krbprincipalaux' not in obj_classes:
888 obj_classes.append('krbprincipalaux')
889 entry_attrs['objectclass'] = obj_classes
...
921 _entry_attrs = ldap.get_entry(dn, ['objectclass'])
922 obj_classes = _entry_attrs['objectclass']
923: if 'ieee802device' not in obj_classes:
924 obj_classes.append('ieee802device')
925 entry_attrs['objectclass'] = obj_classes
...
941 _entry_attrs = ldap.get_entry(dn, ['objectclass'])
942 obj_classes = entry_attrs['objectclass'] = _entry_attrs['objectclass']
943: if 'ipasshhost' not in obj_classes:
944 obj_classes.append('ipasshhost')
```

so that the plugin would be consistent. Rest of framework can be fixed other time.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/761#issuecomment-299172235
felipevolpone
2017-05-04 12:51:36 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/761
Author: felipevolpone
Title: #761: Fixing adding authenticator indicators to host
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/761/head:pr761
git checkout pr761
felipevolpone
2017-05-09 14:46:57 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/761
Author: felipevolpone
Title: #761: Fixing adding authenticator indicators to host
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/761/head:pr761
git checkout pr761
felipevolpone
2017-05-09 18:54:05 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/761
Title: #761: Fixing adding authenticator indicators to host

felipevolpone commented:
"""
Done
"""

See the full comment at https://github.com/freeipa/freeipa/pull/761#issuecomment-300266711
felipevolpone
2017-05-10 13:08:21 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/761
Author: felipevolpone
Title: #761: Fixing adding authenticator indicators to host
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/761/head:pr761
git checkout pr761
stlaz
2017-05-10 14:07:49 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/761
Title: #761: Fixing adding authenticator indicators to host

stlaz commented:
"""
Yes, that seems to have fixed that. Please do squash them now, I guess we can ACK this ;)
"""

See the full comment at https://github.com/freeipa/freeipa/pull/761#issuecomment-300493147
felipevolpone
2017-05-11 13:26:40 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/761
Author: felipevolpone
Title: #761: Fixing adding authenticator indicators to host
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/761/head:pr761
git checkout pr761
felipevolpone
2017-05-11 13:27:13 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/761
Title: #761: Fixing adding authenticator indicators to host

felipevolpone commented:
"""
Cool :)) thanks!
"""

See the full comment at https://github.com/freeipa/freeipa/pull/761#issuecomment-300788709
MartinBasti
2017-05-16 08:34:15 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/761
Title: #761: Fixing adding authenticator indicators to host

Label: +pushed
MartinBasti
2017-05-16 08:34:37 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/761
Author: felipevolpone
Title: #761: Fixing adding authenticator indicators to host
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/761/head:pr761
git checkout pr761
MartinBasti
2017-05-16 08:34:26 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/761
Title: #761: Fixing adding authenticator indicators to host

MartinBasti commented:
"""
master:

* d51af28bdbef8386b6d3bde683be2fc5f73b904e Fixing adding authenticator indicators to host


ipa-4-5:

* 81ae5f4d655bb052c6c0961760dba34e70dcd3c3 Fixing adding authenticator indicators to host


"""

See the full comment at https://github.com/freeipa/freeipa/pull/761#issuecomment-301713644
Loading...