Discussion:
[Freeipa-devel] [freeipa PR#610][opened] [4.3] Fix cookie with Max-Age processing
stlaz
2017-03-16 15:48:51 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/610
Author: stlaz
Title: #610: [4.3] Fix cookie with Max-Age processing
Action: opened

PR body:
"""
When cookie has Max-Age set it tries to get expiration by adding
to a timestamp. Without this patch the timestamp would be set to
None and thus the addition of timestamp + max_age fails

https://pagure.io/freeipa/issue/6718
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/610/head:pr610
git checkout pr610
MartinBasti
2017-03-16 21:23:01 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/610
Title: #610: [4.3] Fix cookie with Max-Age processing

MartinBasti commented:
"""
Please open a new ticket `Backport ...`. Ticket you used is closed in closed milestone
"""

See the full comment at https://github.com/freeipa/freeipa/pull/610#issuecomment-287195160
stlaz
2017-03-17 08:00:33 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/610
Author: stlaz
Title: #610: [4.3] Fix cookie with Max-Age processing
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/610/head:pr610
git checkout pr610
stlaz
2017-03-17 08:00:58 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/610
Title: #610: [4.3] Fix cookie with Max-Age processing

stlaz commented:
"""
The ticket's already there, I just recycled the old commit message and forgot to replace it.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/610#issuecomment-287290891
MartinBasti
2017-03-20 15:54:10 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/610
Title: #610: [4.3] Fix cookie with Max-Age processing

Label: +ack
tomaskrizek
2017-03-20 18:12:35 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/610
Title: #610: [4.3] Fix cookie with Max-Age processing

tomaskrizek commented:
"""
ipa-4-3:

* 0d66046e501a4a1a09a0a74a96a499cb88ffb03b Fix cookie with Max-Age processing
* 71475e3153117e554d22a2a27d7882ba4f890be8 Add debug log in case cookie retrieval went wrong
"""

See the full comment at https://github.com/freeipa/freeipa/pull/610#issuecomment-287849317
tomaskrizek
2017-03-20 18:12:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/610
Title: #610: [4.3] Fix cookie with Max-Age processing

Label: +pushed
tomaskrizek
2017-03-20 18:12:39 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/610
Author: stlaz
Title: #610: [4.3] Fix cookie with Max-Age processing
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/610/head:pr610
git checkout pr610

Loading...