[Freeipa-devel] [freeipa PR#548][opened] ipa-server-install: add --setup-kra option

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/548
Author: MartinBasti
Title: #548: ipa-server-install: add --setup-kra option
Action: opened

PR body:
"""

"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/548/head:pr548
git checkout pr548

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/548
Title: #548: ipa-server-install: add --setup-kra option

HonzaCholasta commented:
"""
NACK on the "KRA: run install and install_check only when KRA should be installed" commit. The end goal for all component installers is to make them isolated and handle their options themselves, so that they can be packaged separately (among other things). This commit takes the code in the opposite direction. Also it does not make the code more readable because it is inconsistent with the CA installer.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/548#issuecomment-284983950

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/548
Author: MartinBasti
Title: #548: ipa-server-install: add --setup-kra option
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/548/head:pr548
git checkout pr548

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/548
Title: #548: ipa-server-install: add --setup-kra option

MartinBasti commented:
"""
Given that there is no time, I dropped commit you NACKed as it unneeded for this PR, but please note my disagreement about a way how `kra.py` handles `--setup-kra` option for the future release.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/548#issuecomment-285020252

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/548
Title: #548: ipa-server-install: add --setup-kra option

Label: +ack

[dkupka]

URL: https://github.com/freeipa/freeipa/pull/548
Title: #548: ipa-server-install: add --setup-kra option

Label: +pushed

[dkupka]

URL: https://github.com/freeipa/freeipa/pull/548
Author: MartinBasti
Title: #548: ipa-server-install: add --setup-kra option
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/548/head:pr548
git checkout pr548

[dkupka]

URL: https://github.com/freeipa/freeipa/pull/548
Title: #548: ipa-server-install: add --setup-kra option

dkupka commented:
"""
master:

* 4006cbbc02c368ac9e5e3721613158decb34fd37 KRA: add --setup-kra to ipa-server-install
* 25fa2bb6c9fa1b498330b13c9a6116b646eb75ba tests: use --setup-kra in tests
"""

See the full comment at https://github.com/freeipa/freeipa/pull/548#issuecomment-285061152