Discussion:
[Freeipa-devel] [freeipa PR#675][opened] [WIP] Fix PKCS11 helper
MartinBasti
2017-03-29 17:06:25 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Author: MartinBasti
Title: #675: [WIP] Fix PKCS11 helper
Action: opened

PR body:
"""
Slots in HSM are not assigned statically, we have to chose proper
slot from token label.

Softhsm i2.2.0 changed this behavior and now slots can change over
time (it is allowed by pkcs11 standard).

Changelog:
* created method get_slot() that returns slot number from
used label
* replaces usage of slot in __init__ method of P11_Helper
with label
* slot is dynamically detected from token label before
session is opened
* pkcs11-util --init-token now uses '--free' instead '--slot'
which uses first free slot (we don't care about slot numbers
anymore)

https://pagure.io/freeipa/issue/6692
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/675/head:pr675
git checkout pr675
MartinBasti
2017-03-29 17:23:11 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Author: MartinBasti
Title: #675: [WIP] Fix PKCS11 helper
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/675/head:pr675
git checkout pr675
MartinBasti
2017-03-30 08:17:09 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Author: MartinBasti
Title: #675: [WIP] Fix PKCS11 helper
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/675/head:pr675
git checkout pr675
stlaz
2017-03-30 08:46:55 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Title: #675: [WIP] Fix PKCS11 helper

stlaz commented:
"""
`cffi.api.CDefError: cannot parse "typedef CK_RV (*CK_C_GetSlotList) (CK_BBOOL tokenPresent,`
-> you're using CK_BBOOL type before defining it.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/675#issuecomment-290344169
stlaz
2017-03-30 08:59:20 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Title: #675: [WIP] Fix PKCS11 helper

stlaz commented:
"""
`cffi.api.CDefError: cannot parse "typedef CK_RV (*CK_C_GetSlotList) (CK_BBOOL tokenPresent,`
-> you're using CK_BBOOL type before defining it.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/675#issuecomment-290344169
MartinBasti
2017-03-31 12:16:59 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Author: MartinBasti
Title: #675: [WIP] Fix PKCS11 helper
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/675/head:pr675
git checkout pr675
MartinBasti
2017-04-05 15:05:13 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Author: MartinBasti
Title: #675: [WIP] Fix PKCS11 helper
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/675/head:pr675
git checkout pr675
MartinBasti
2017-04-05 15:56:17 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Author: MartinBasti
Title: #675: [WIP] Fix PKCS11 helper
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/675/head:pr675
git checkout pr675
MartinBasti
2017-04-05 16:40:48 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Title: #675: [4.5, master] Fix PKCS11 helper

MartinBasti commented:
"""
In 50% cases DNSSEC works for me :-). Ready for review.

(The issue was unrelated to PKCS11, I had somehow broken machine probably)
"""

See the full comment at https://github.com/freeipa/freeipa/pull/675#issuecomment-291921421
MartinBasti
2017-04-05 16:39:06 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Author: MartinBasti
Title: #675: [4.5, master] Fix PKCS11 helper
Action: edited

Changed field: title
Original value:
"""
[WIP] Fix PKCS11 helper
"""
stlaz
2017-04-11 07:54:19 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Title: #675: [4.5, master] Fix PKCS11 helper

stlaz commented:
"""
I ran the integration test and the result was fine, ACK.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/675#issuecomment-293180206
stlaz
2017-04-11 07:54:25 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Title: #675: [4.5, master] Fix PKCS11 helper

Label: +ack
MartinBasti
2017-04-12 07:54:52 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Title: #675: [4.5, master] Fix PKCS11 helper

MartinBasti commented:
"""
ipa-4-5:

* e6b2ed6b68589ff7ee39b95559836af54f39e2de Fix PKCS11 helper


master:

* e8f2a415b3dcba30b0c39cd542acd6b459f46957 Fix PKCS11 helper


"""

See the full comment at https://github.com/freeipa/freeipa/pull/675#issuecomment-293502061
MartinBasti
2017-04-12 07:54:56 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Title: #675: [4.5, master] Fix PKCS11 helper

Label: +pushed
MartinBasti
2017-04-12 07:55:00 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/675
Author: MartinBasti
Title: #675: [4.5, master] Fix PKCS11 helper
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/675/head:pr675
git checkout pr675

Loading...