[Freeipa-devel] [freeipa PR#587][opened] Python 3: Fix session storage

[tiran]

URL: https://github.com/freeipa/freeipa/pull/587
Author: tiran
Title: #587: Python 3: Fix session storage
Action: opened

PR body:
"""
ctypes can only handle bytes, not text. Encode and decode all incoming
and outgoing text from UTF-8 to bytes.

Signed-off-by: Christian Heimes <***@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/587/head:pr587
git checkout pr587

[tiran]

URL: https://github.com/freeipa/freeipa/pull/587
Title: #587: Python 3: Fix session storage

tiran commented:
"""
@simo5 is UTF-8 correct or are keys and values ASCII only?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/587#issuecomment-286495619

[simo5]

URL: https://github.com/freeipa/freeipa/pull/587
Title: #587: Python 3: Fix session storage

Label: +ack

[simo5]

URL: https://github.com/freeipa/freeipa/pull/587
Title: #587: Python 3: Fix session storage

simo5 commented:
"""
Technically principal names could use any encoding ... but we make the assumption they are utf-8 in freeIPA, so this should be ok.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/587#issuecomment-286518991

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/587
Title: #587: Python 3: Fix session storage

MartinBasti commented:
"""
master:

* 42bc778c0c1de91f0d8dc695dfee4e5aea4cc1f0 Python 3: Fix session storage
"""

See the full comment at https://github.com/freeipa/freeipa/pull/587#issuecomment-286831940

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/587
Title: #587: Python 3: Fix session storage

Label: +pushed

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/587
Author: tiran
Title: #587: Python 3: Fix session storage
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/587/head:pr587
git checkout pr587