[Freeipa-devel] [freeipa PR#682][opened] ipserver/dcerpc: unify error processing

[abbra]

URL: https://github.com/freeipa/freeipa/pull/682
Author: abbra
Title: #682: ipserver/dcerpc: unify error processing
Action: opened

PR body:
"""
Samba error code reporting changes from version to version but we also
did not provide proper input into DCE RPC error processing method we
have.

Unify error processing and add few more fallback entries.

With Samba 4.7 we'll have to change it again because error code
processing for Samba Python modules will change with introduction of
samba.ntstatus and samba.werror modules.

Note that this commit also changes a message returned for error code
-1073741772 (NT_STATUS_OBJECT_NOT_FOUND) because it is more general one.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/682/head:pr682
git checkout pr682

[abbra]

URL: https://github.com/freeipa/freeipa/pull/682
Title: #682: ipserver/dcerpc: unify error processing

abbra commented:
"""
Note: this is WIP, I'm waiting for Sudhir to provide a bug and logs that show the changes he encountered when running existing test suite against Samba 4.6.2.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/682#issuecomment-291070811

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/682
Author: abbra
Title: #682: ipserver/dcerpc: unify error processing
Action: edited

Changed field: title
Original value:
"""
ipserver/dcerpc: unify error processing
"""

[abbra]

URL: https://github.com/freeipa/freeipa/pull/682
Author: abbra
Title: #682: [WIP] ipserver/dcerpc: unify error processing
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/682/head:pr682
git checkout pr682

[abbra]

URL: https://github.com/freeipa/freeipa/pull/682
Title: #682: [WIP] ipserver/dcerpc: unify error processing

abbra commented:
"""
Updated patches and descriptions to include bug references.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/682#issuecomment-292545612

[abbra]

URL: https://github.com/freeipa/freeipa/pull/682
Author: abbra
Title: #682: [WIP] ipserver/dcerpc: unify error processing
Action: edited

Changed field: title
Original value:
"""
[WIP] ipserver/dcerpc: unify error processing
"""

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/682
Title: #682: ipserver/dcerpc: unify error processing

MartinBasti commented:
"""
Please fix issues found by pylint
```
************* Module ipaserver.plugins.trust
ipaserver/plugins/trust.py:1753: [W0612(unused-variable), trust_fetch_domains.execute] Unused variable 'trust_direction')
ipaserver/plugins/trust.py:1754: [W0612(unused-variable), trust_fetch_domains.execute] Unused variable 'is_nontransitive')
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/682#issuecomment-292560905

[pvoborni]

URL: https://github.com/freeipa/freeipa/pull/682
Title: #682: ipserver/dcerpc: unify error processing

pvoborni commented:
"""
A ticket was created for this PR: https://pagure.io/freeipa/issue/6859
"""

See the full comment at https://github.com/freeipa/freeipa/pull/682#issuecomment-292910558

[abbra]

URL: https://github.com/freeipa/freeipa/pull/682
Author: abbra
Title: #682: ipserver/dcerpc: unify error processing
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/682/head:pr682
git checkout pr682

[abbra]

URL: https://github.com/freeipa/freeipa/pull/682
Author: abbra
Title: #682: ipserver/dcerpc: unify error processing
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/682/head:pr682
git checkout pr682

[abbra]

URL: https://github.com/freeipa/freeipa/pull/682
Author: abbra
Title: #682: ipaserver/dcerpc: unify error processing
Action: edited

Changed field: title
Original value:
"""
ipserver/dcerpc: unify error processing
"""

[abbra]

URL: https://github.com/freeipa/freeipa/pull/682
Author: abbra
Title: #682: ipaserver/dcerpc: unify error processing
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/682/head:pr682
git checkout pr682

[abbra]

URL: https://github.com/freeipa/freeipa/pull/682
Author: abbra
Title: #682: ipaserver/dcerpc: unify error processing
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/682/head:pr682
git checkout pr682

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/682
Title: #682: ipaserver/dcerpc: unify error processing

MartinBasti commented:
"""
Code LGTM
"""

See the full comment at https://github.com/freeipa/freeipa/pull/682#issuecomment-293241513

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/682
Title: #682: ipaserver/dcerpc: unify error processing

Label: +ack

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/682
Title: #682: ipaserver/dcerpc: unify error processing

Label: +pushed

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/682
Title: #682: ipaserver/dcerpc: unify error processing

MartinBasti commented:
"""
master:

* aef77b3529540ad12939a2cc54996c341c5d49d3 ipaserver/dcerpc: unify error processing
* e560899cce20ca7773a5ce46a1c29db1349e8ec7 trust: always use oddjobd helper for fetching trust information


ipa-4-5:

* bbb23fc87a51218960d54f9eccc23405c5c5ded6 ipaserver/dcerpc: unify error processing
* 45e1998c51e281c8371ae31762016cb1ddec406f trust: always use oddjobd helper for fetching trust information


"""

See the full comment at https://github.com/freeipa/freeipa/pull/682#issuecomment-293242018

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/682
Author: abbra
Title: #682: ipaserver/dcerpc: unify error processing
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/682/head:pr682
git checkout pr682