[Freeipa-devel] [freeipa PR#726][opened] Add check for directory name

[Akasurde]

URL: https://github.com/freeipa/freeipa/pull/726
Author: Akasurde
Title: #726: Add check for directory name
Action: opened

PR body:
"""
Fix adds check to verify if user provided input is not
a directory when filename is required.

Fixes: https://pagure.io/freeipa/issue/6883

Signed-off-by: Abhijeet Kasurde <***@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/726/head:pr726
git checkout pr726

[Akasurde]

URL: https://github.com/freeipa/freeipa/pull/726
Author: Akasurde
Title: #726: Add check for directory name
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/726/head:pr726
git checkout pr726

[Akasurde]

URL: https://github.com/freeipa/freeipa/pull/726
Author: Akasurde
Title: #726: Add check for directory name
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/726/head:pr726
git checkout pr726

[tiran]

URL: https://github.com/freeipa/freeipa/pull/726
Title: #726: Add check for directory name

tiran commented:
"""
What about other types that might cause trouble, e.g. socket, fifo, device files, dangling symlinks?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/726#issuecomment-296572324

[Akasurde]

URL: https://github.com/freeipa/freeipa/pull/726
Title: #726: Add check for directory name

Akasurde commented:
"""
@tiran Do you think we should allow only files here ?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/726#issuecomment-296579941

[Akasurde]

URL: https://github.com/freeipa/freeipa/pull/726
Author: Akasurde
Title: #726: Add check for directory name
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/726/head:pr726
git checkout pr726

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/726
Title: #726: Add check for directory name

stlaz commented:
"""
Obviously we can't push this until the tests pass.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/726#issuecomment-299112001

[Akasurde]

URL: https://github.com/freeipa/freeipa/pull/726
Author: Akasurde
Title: #726: Add check for directory name
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/726/head:pr726
git checkout pr726