[Freeipa-devel] [freeipa PR#659][opened] WebUI: Allow to add certs to certmapping with CERT LINES around

[pvomacka]

URL: https://github.com/freeipa/freeipa/pull/659
Author: pvomacka
Title: #659: WebUI: Allow to add certs to certmapping with CERT LINES around
Action: opened

PR body:
"""
The certificate to the certmapping might be inserted as
base64 encoded blob. This patch allows to also insert the certificate
blob with surrounding "-----BEGIN CERTIFICATE-----" and
"-----END CERTIFICATE-----" lines. This behavior is the same in
widget for assigning certificates to users, so the change helps
WebUI to be more consistent.

https://pagure.io/freeipa/issue/6772
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/659/head:pr659
git checkout pr659

[flo-renaud]

URL: https://github.com/freeipa/freeipa/pull/659
Title: #659: WebUI: Allow to add certs to certmapping with CERT LINES around

flo-renaud commented:
"""
Hi @pvomacka ,

thank you for the patch, it works as expected.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/659#issuecomment-289508460

[pvoborni]

URL: https://github.com/freeipa/freeipa/pull/659
Title: #659: WebUI: Allow to add certs to certmapping with CERT LINES around

pvoborni commented:
"""
Code LGTM, ACK give that it works for @flo-renaud
"""

See the full comment at https://github.com/freeipa/freeipa/pull/659#issuecomment-289511086

[pvoborni]

URL: https://github.com/freeipa/freeipa/pull/659
Title: #659: WebUI: Allow to add certs to certmapping with CERT LINES around

Label: +ack

[pvomacka]

URL: https://github.com/freeipa/freeipa/pull/659
Title: #659: WebUI: Allow to add certs to certmapping with CERT LINES around

Label: +pushed

[pvomacka]

URL: https://github.com/freeipa/freeipa/pull/659
Author: pvomacka
Title: #659: WebUI: Allow to add certs to certmapping with CERT LINES around
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/659/head:pr659
git checkout pr659

[pvomacka]

URL: https://github.com/freeipa/freeipa/pull/659
Title: #659: WebUI: Allow to add certs to certmapping with CERT LINES around

pvomacka commented:
"""
ipa-4-5:

* eda23a9847197513555f6237b46c658365dfc12d WebUI: Allow to add certs to certmapping with CERT LINES around
master:

* 84b38b6793cbc45d36c39abf79893e22e90baac6 WebUI: Allow to add certs to certmapping with CERT LINES around
"""

See the full comment at https://github.com/freeipa/freeipa/pull/659#issuecomment-289513389