[Freeipa-devel] [freeipa PR#618][opened] [WIP] Tox testing support for client wheel packages

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: opened

PR body:
"""
Depends on PR #613
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Title: #618: [WIP] Tox testing support for client wheel packages

tiran commented:
"""
Tox testing should also be integrated into Travis CI to catch bugs like https://pagure.io/freeipa/issue/6816. The tox script will automatically test features like ```./configure --disable-server```, ```bdist_wheel``` and ```wheel_bundle```.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/618#issuecomment-289410234

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: [WIP] Tox testing support for client wheel packages
Action: edited

Changed field: title
Original value:
"""
[WIP] Tox testing support for client wheel packages
"""

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: Tox testing support for client wheel packages
Action: edited

Changed field: body
Original value:
"""
Depends on PR #613
"""

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/618
Title: #618: Tox testing support for client wheel packages

MartinBasti commented:
"""
I ran `tox` and I received following output:

```
ERROR: py27: could not install deps [ipaclient, ipatests]; v = InvocationError('/tmp/freeipa/.tox-install.sh wheel_bundle /tmp/freeipa/.tox/py27/bin/python /tmp/freeipa/.tox/py27/lib/python2.7/site-packages ipaclient ipatests (see /tmp/freeipa/.tox/py27/log/py27-1.log)', 2)
ERROR: py35: could not install deps [ipaclient, ipatests]; v = InvocationError('/tmp/freeipa/.tox-install.sh wheel_bundle /tmp/freeipa/.tox/py35/bin/python /tmp/freeipa/.tox/py35/lib/python3.5/site-packages ipaclient ipatests (see /tmp/freeipa/.tox/py35/log/py35-1.log)', 2)
ERROR: py36: could not install deps [ipaclient, ipatests]; v = InvocationError('/tmp/freeipa/.tox-install.sh wheel_bundle /tmp/freeipa/.tox/py36/bin/python /tmp/freeipa/.tox/py36/lib/python3.6/site-packages ipaclient ipatests (see /tmp/freeipa/.tox/py36/log/py36-1.log)', 2)
ERROR: pylint2: could not install deps [ipaclient, ipapython[certmonger], pylint]; v = InvocationError('/tmp/freeipa/.tox-install.sh wheel_bundle /tmp/freeipa/.tox/pylint2/bin/python /tmp/freeipa/.tox/pylint2/lib/python2.7/site-packages ipaclient ipapython[certmonger] pylint (see /tmp/freeipa/.tox/pylint2/log/pylint2-1.log)', 2)
ERROR: pylint3: could not install deps [ipaclient, ipapython[certmonger], pylint]; v = InvocationError('/tmp/freeipa/.tox-install.sh wheel_bundle /tmp/freeipa/.tox/pylint3/bin/python /tmp/freeipa/.tox/pylint3/lib/python3.5/site-packages ipaclient ipapython[certmonger] pylint (see /tmp/freeipa/.tox/pylint3/log/pylint3-1.log)', 2)
pypi: commands succeeded
```

Is it expected?

I had applied following patches:

* Correct PyPI package dependencies
* Stabilize make pypi_packages
* Replace hard-coded kdcproxy path with WSGI script
"""

See the full comment at https://github.com/freeipa/freeipa/pull/618#issuecomment-293510308

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Title: #618: Tox testing support for client wheel packages

tiran commented:
"""
Why are you mixing PRs? Don't mix PRs.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/618#issuecomment-293516717

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Title: #618: Tox testing support for client wheel packages

tiran commented:
"""
I've rebased the branch on master, just in case. Tox works for me before and after rebase.

```
$ git clean -xdf
$ tox
...
py27: commands succeeded
py35: commands succeeded
py36: commands succeeded
pylint2: commands succeeded
pylint3: commands succeeded
pypi: commands succeeded
congratulations :)
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/618#issuecomment-293562432

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Title: #618: Tox testing support for client wheel packages

tiran commented:
"""
I added tox to wheel build requirements. Now you can install all dependencies with dnf builddep.

```
$ sudo dnf copr enable @freeipa/freeipa-master
$ sudo dnf install redhat-rpm-config
$ sudo dnf builddep --spec freeipa.spec.in --define "with_wheels 1"
$ tox
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/618#issuecomment-293568255

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/618
Title: #618: Tox testing support for client wheel packages

MartinBasti commented:
"""
Thanks, I'll try again, it needs rebase again
"""

See the full comment at https://github.com/freeipa/freeipa/pull/618#issuecomment-293586483

[tiran]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: Tox testing support for client wheel packages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/618
Title: #618: Tox testing support for client wheel packages

MartinBasti commented:
"""
Thnks, works for me.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/618#issuecomment-293599732

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/618
Title: #618: Tox testing support for client wheel packages

Label: +ack

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/618
Title: #618: Tox testing support for client wheel packages

Label: +pushed

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/618
Title: #618: Tox testing support for client wheel packages

MartinBasti commented:
"""
master:

* 3a5b3be8b92a509d207d814c9fe294ee7b4e81c4 tox testing support for client wheel packages


"""

See the full comment at https://github.com/freeipa/freeipa/pull/618#issuecomment-293603161

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/618
Author: tiran
Title: #618: Tox testing support for client wheel packages
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/618/head:pr618
git checkout pr618