Discussion:
[Freeipa-devel] [freeipa PR#637][opened] ldap2: use LDAP whoami operation to retrieve bind DN for current connection
abbra
2017-03-22 11:04:42 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/637
Author: abbra
Title: #637: ldap2: use LDAP whoami operation to retrieve bind DN for current connection
Action: opened

PR body:
"""
For external users which are mapped to some DN in LDAP server, we
wouldn't neccesary be able to find a kerberos data in their LDAP entry.
Instead of searching for Kerberos principal use actual DN we are bound
to because for get_effective_rights LDAP control we only need the DN
itself.

Fixes https://pagure.io/freeipa/issue/6797
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/637/head:pr637
git checkout pr637
martbab
2017-03-22 11:42:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/637
Title: #637: ldap2: use LDAP whoami operation to retrieve bind DN for current connection

martbab commented:
"""
LGTM but lint has some complains probably related to my in-line comment.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/637#issuecomment-288373921
pvomacka
2017-03-22 11:50:46 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/637
Title: #637: ldap2: use LDAP whoami operation to retrieve bind DN for current connection

pvomacka commented:
"""
Hi @abbra, thank you for patch, works for me.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/637#issuecomment-288375637
abbra
2017-03-22 13:52:00 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/637
Author: abbra
Title: #637: ldap2: use LDAP whoami operation to retrieve bind DN for current connection
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/637/head:pr637
git checkout pr637
abbra
2017-03-22 13:52:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/637
Title: #637: ldap2: use LDAP whoami operation to retrieve bind DN for current connection

abbra commented:
"""
Removed try: finally: block, I agree that it is better to propagate error up the stack.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/637#issuecomment-288404454
martbab
2017-03-22 16:18:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/637
Title: #637: ldap2: use LDAP whoami operation to retrieve bind DN for current connection

Label: +ack
martbab
2017-03-22 16:19:51 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/637
Title: #637: ldap2: use LDAP whoami operation to retrieve bind DN for current connection

Label: +pushed
martbab
2017-03-22 16:19:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/637
Title: #637: ldap2: use LDAP whoami operation to retrieve bind DN for current connection

martbab commented:
"""
ipa-4-5:

* 7d48fb841a23e9f036f3d449d80623d1225c820a ldap2: use LDAP whoami operation to retrieve bind DN for current connection
master:

* 7324451834ec03786fda947679f750fe2a72f29c ldap2: use LDAP whoami operation to retrieve bind DN for current connection
"""

See the full comment at https://github.com/freeipa/freeipa/pull/637#issuecomment-288453968
martbab
2017-03-22 16:19:57 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/637
Author: abbra
Title: #637: ldap2: use LDAP whoami operation to retrieve bind DN for current connection
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/637/head:pr637
git checkout pr637

Loading...