[Freeipa-devel] [bind-dyndb-ldap PR#17][opened] settings: skip unconfigured values

[tomaskrizek]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/17
Author: tomaskrizek
Title: #17: settings: skip unconfigured values
Action: opened

PR body:
"""
When a value is not configured in settings map, it is skipped.
If it is the last processed value, the result of ISC_R_NOTFOUND
would cause the cleanup section of the function fail. Since
unconfigured values are allowed and expected, override the result
to ISC_R_SUCCESS in this case to prevent triggerring an error.

https://pagure.io/bind-dyndb-ldap/issue/172

---

Also removed obsolete options from the map.
"""

To pull the PR as Git branch:
git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap
git fetch ghbind-dyndb-ldap pull/17/head:pr17
git checkout pr17

[tomaskrizek]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/17
Title: #17: settings: skip unconfigured values

tomaskrizek commented:
"""
@MartinBasti Would you please test this PR? You can just install IPA with DNS and then remove `server_id` from `named.conf`. With this patch, it should be possible to sucessfully restart named-pkcs11. Before, it failed.
"""

See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/17#issuecomment-293552509

[MartinBasti]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/17
Title: #17: settings: skip unconfigured values

MartinBasti commented:
"""
LGTM
"""

See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/17#issuecomment-296617030

[tomaskrizek]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/17
Title: #17: settings: skip unconfigured values

Label: +ack

[tomaskrizek]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/17
Author: tomaskrizek
Title: #17: settings: skip unconfigured values
Action: closed

To pull the PR as Git branch:
git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap
git fetch ghbind-dyndb-ldap pull/17/head:pr17
git checkout pr17

[tomaskrizek]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/17
Title: #17: settings: skip unconfigured values

Label: +pushed

[tomaskrizek]

URL: https://github.com/freeipa/bind-dyndb-ldap/pull/17
Title: #17: settings: skip unconfigured values

tomaskrizek commented:
"""
master

- 41461fc444170ffd9b5459e2f0b2480f3288cc1d
- 7a67f77b66a680df1c21429e7c4e2dd001e86046
"""

See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/17#issuecomment-297364657