[Freeipa-devel] [freeipa PR#706][opened] Fix CA-less to CA-full upgrade

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/706
Author: stlaz
Title: #706: Fix CA-less to CA-full upgrade
Action: opened

PR body:
"""
CertDB would have always created a directory on initialization. This
behavior changes here by replacing the truncate argument with create
which will only create the database when really required.

https://pagure.io/freeipa/issue/6853
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/706/head:pr706
git checkout pr706

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/706
Title: #706: Fix CA-less to CA-full upgrade

stlaz commented:
"""
I am not a big fan of creating directories on object initialization, thus this change. Another way of doing this would be of course to check whether the pki-tomcat/alias dir exists in the first place and not create the CertDB there.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/706#issuecomment-293187666

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/706
Title: #706: Fix CA-less to CA-full upgrade

Label: +ack

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/706
Title: #706: Fix CA-less to CA-full upgrade

Label: +pushed

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/706
Title: #706: Fix CA-less to CA-full upgrade

tomaskrizek commented:
"""
master:

* 9ac56e47d78582fbc2911f67a7344bcce321842f Fix CA-less to CA-full upgrade


ipa-4-5:

* 7a6f78bab8f9f76bf37fb105ec2537676d889cc2 Fix CA-less to CA-full upgrade


"""

See the full comment at https://github.com/freeipa/freeipa/pull/706#issuecomment-293593075

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/706
Author: stlaz
Title: #706: Fix CA-less to CA-full upgrade
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/706/head:pr706
git checkout pr706